Develop (!1) · Merge Requests · Administrator / print-demo

Develop

合并测试sonar

{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved

Administrator
@root started a discussion on commit 4dec70b8 Apr 22, 2020
Administrator @root commented Apr 22, 2020

Master

SonarQube analysis reported 9 issues

🚫 1 critical

⚠ 4 major

🔽 4 minor

Note: The following issues were found on lines that were not modified in the commit. Because these issues can't be reported as line comments, they are summarized here:

🚫 Make sure this expression can't be zero before doing this division. 📘

⚠ This block of commented-out lines of code should be removed. 📘

⚠ Replace this use of System.out or System.err by a logger. 📘

⚠ Remove this useless assignment to local variable "result". 📘

⚠ Either remove or fill this block of code. 📘

🔽 Remove this unused import 'org.apache.commons.logging.Log'. 📘

🔽 Remove this unused import 'org.apache.commons.logging.LogFactory'. 📘

🔽 Remove this empty class, write its code or make it an "interface". 📘

🔽 Remove this unused "result" local variable. 📘

SonarQube analysis reported 9 issues * :no_entry_sign: 1 critical * :warning: 4 major * :arrow_down_small: 4 minor Note: The following issues were found on lines that were not modified in the commit. Because these issues can't be reported as line comments, they are summarized here: 1. :no_entry_sign: [Make sure this expression can't be zero before doing this division.](http://git.zhiweidata.top/root/print-demo/blob/4dec70b8f40b3d94b93b22ffbe1050aa7f3e4227/src/main/java/com/zhiweidata/printdemo/PrintDemoApplication.java#L19) [:blue_book:](http://192.168.0.51:9000/coding_rules#rule_key=squid%3AS3518) 1. :warning: [This block of commented-out lines of code should be removed.](http://git.zhiweidata.top/root/print-demo/blob/4dec70b8f40b3d94b93b22ffbe1050aa7f3e4227/src/main/java/com/zhiweidata/printdemo/PrintDemoApplication.java#L3) [:blue_book:](http://192.168.0.51:9000/coding_rules#rule_key=squid%3ACommentedOutCodeLine) 1. :warning: [Replace this use of System.out or System.err by a logger.](http://git.zhiweidata.top/root/print-demo/blob/4dec70b8f40b3d94b93b22ffbe1050aa7f3e4227/src/main/java/com/zhiweidata/printdemo/PrintDemoApplication.java#L18) [:blue_book:](http://192.168.0.51:9000/coding_rules#rule_key=squid%3AS106) 1. :warning: [Remove this useless assignment to local variable "result".](http://git.zhiweidata.top/root/print-demo/blob/4dec70b8f40b3d94b93b22ffbe1050aa7f3e4227/src/main/java/com/zhiweidata/printdemo/PrintDemoApplication.java#L19) [:blue_book:](http://192.168.0.51:9000/coding_rules#rule_key=squid%3AS1854) 1. :warning: [Either remove or fill this block of code.](http://git.zhiweidata.top/root/print-demo/blob/4dec70b8f40b3d94b93b22ffbe1050aa7f3e4227/src/main/java/com/zhiweidata/printdemo/PrintDemoApplication.java#L25) [:blue_book:](http://192.168.0.51:9000/coding_rules#rule_key=squid%3AS00108) 1. :arrow_down_small: [Remove this unused import 'org.apache.commons.logging.Log'.](http://git.zhiweidata.top/root/print-demo/blob/4dec70b8f40b3d94b93b22ffbe1050aa7f3e4227/src/main/java/com/zhiweidata/printdemo/LogTest.java#L4) [:blue_book:](http://192.168.0.51:9000/coding_rules#rule_key=squid%3AUselessImportCheck) 1. :arrow_down_small: [Remove this unused import 'org.apache.commons.logging.LogFactory'.](http://git.zhiweidata.top/root/print-demo/blob/4dec70b8f40b3d94b93b22ffbe1050aa7f3e4227/src/main/java/com/zhiweidata/printdemo/LogTest.java#L5) [:blue_book:](http://192.168.0.51:9000/coding_rules#rule_key=squid%3AUselessImportCheck) 1. :arrow_down_small: [Remove this empty class, write its code or make it an "interface".](http://git.zhiweidata.top/root/print-demo/blob/4dec70b8f40b3d94b93b22ffbe1050aa7f3e4227/src/main/java/com/zhiweidata/printdemo/LogTest.java#L7) [:blue_book:](http://192.168.0.51:9000/coding_rules#rule_key=squid%3AS2094) 1. :arrow_down_small: [Remove this unused "result" local variable.](http://git.zhiweidata.top/root/print-demo/blob/4dec70b8f40b3d94b93b22ffbe1050aa7f3e4227/src/main/java/com/zhiweidata/printdemo/PrintDemoApplication.java#L19) [:blue_book:](http://192.168.0.51:9000/coding_rules#rule_key=squid%3AS1481)

Please register or sign in to reply
Administrator @root
mentioned in commit c7923da1
Apr 22, 2020

mentioned in commit c7923da1

mentioned in commit c7923da1479378e9661a037bca9b1d2802cd08a9

Toggle commit list
Administrator @root
merged
Apr 22, 2020

merged

merged

Toggle commit list

Please register or to comment

Develop

Check out, review, and merge locally

Revert this merge request

Cherry-pick this merge request